Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Remove long-running Snap permission #20951

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Sep 19, 2023

Description

This PR removes long-running Snap endowment/permission.

Snaps team have decided to remove this endowment because of its unpredictable security concerns around running Snaps indefinitely. This endowment is removed in favor of the new endowments that will be focused on solving certain use cases that require snap to be running for more time than default.

Related issues

Fixes #945

Related PR

MetaMask/snaps#1751 (required)
MetaMask/metamask-docs#919

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd self-assigned this Sep 19, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 19, 2023
@david0xd david0xd force-pushed the dd/remove-endowment-long-running branch from 67f1d37 to e426bb9 Compare September 19, 2023 11:00
@david0xd david0xd force-pushed the dd/remove-endowment-long-running branch from e426bb9 to 99fddd6 Compare September 27, 2023 09:32
@david0xd david0xd changed the base branch from develop to fb/bump-snaps-2.0.1 September 27, 2023 09:33
@david0xd david0xd force-pushed the dd/remove-endowment-long-running branch from 99fddd6 to db3a1a3 Compare September 27, 2023 09:33
@david0xd david0xd marked this pull request as ready for review September 27, 2023 09:34
@david0xd david0xd requested review from a team as code owners September 27, 2023 09:34
@david0xd david0xd merged commit 9cd148a into fb/bump-snaps-2.0.1 Sep 27, 2023
6 checks passed
@david0xd david0xd deleted the dd/remove-endowment-long-running branch September 27, 2023 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove endowment:long-running from Snap APIs
2 participants